Add all user to a group(help needed)

Hello,

I'm trying to write a script to place all users in the "DB Admin" group and below is the code I am currenly having issue with; what am I doing wrong? It attempts to add the first user to the groups then it fails and I get a prue vitrual error???

const Group g = find("DB Admin") 
if(null g)
{ halt }
 
Skip AllUserList = create()
 
int cnt = 0
User u = null 
for u in userList do {
    string s = u.name
        put(AllUserList, cnt++, s)
}
 
string sUserName = null
for sUserName in AllUserList do {
        User cUser = find(sUserName)
        if(null cUser) continue
        addMember(g, cUser)
        
        // save new user list
        if (saveDirectory() == null) 
        {
                // refresh
                if (loadDirectory() == null)
                {
                        // inform user
                        infoBox("User '"sUserName"'was added successfully.\n")
                } 
                else 
                {
                        // warn user
                        errorBox("Failed to load user list.\n")
                }
        } 
        else 
        {
                // warn user
                errorBox("Failed to save user list.\n")
        }
}
 
delete AllUserList

Re: Add all user to a group(help needed)
SystemAdmin - Tue Dec 04 15:34:15 EST 2012

I believe I fixed my issue is my logic correct now?
 

pragma runLim, 0
 
const string sgroup = "DB Admin"
 
// Environment variable
const string USER_PROFILE = getenv("USERPROFILE") // Desktop variable
// -------------------------------------------------------------------
const string OUT_FILE = USER_PROFILE "\\Desktop\\UserGroupUpdate.txt"
const Stream OUTPUT
// -------------------------------------------------------------------
bool writeFileHeader(string filename)
{ // Try to open output file
  bool returnValue = false
  if (canOpenFile(filename, true))
  { // User can write to Stream
    returnValue = true
    OUTPUT = write filename
  } // User can write to Stream
  return returnValue
} // Try to open output file
// -------------------------------------------------------------------
    
void msgPrint(string msg)
{
        OUTPUT << msg
}
 
void UpdateUsers(string sUserName, string sgroup)
{
        bool saving = false
        
        if(existsGroup(sgroup))
        {
                Group g = find(sgroup)
                if(g == null)
                {
                        // warn user
                        msgPrint("Failed to find group.\n")
                }
                else
                {
                        User cUser = find(sUserName)
                        if(cUser == null)
                        {
                                // warn user
                                msgPrint("Failed to find user. '"sUserName".\n")
                        }
                        else
                        {
                                if(!member(g,cUser))
                                {            
                                        // add user group
                                        addMember(g, cUser)
                                        saving = true
                                }
                        }
                }
        }
        else
        {
                // warn user
                msgPrint("Group doesn't exist '"sgroup"'.\n")
        }
        
        if(saving)
        {
                // save new user list
                if (saveDirectory() == null) 
                {
                   // refresh
                   if (loadDirectory() == null)
                   {
                         // inform user
                         msgPrint("User '"sUserName"'was added successfully.\n")
                   } 
                   else 
                   {
                         // warn user
                         msgPrint("Failed to load user list.\n")
                   }
                } 
                else 
                {
                        // warn user
                        msgPrint("Failed to save user list.\n")
                }
        }
}
 
 
 
/************************************
        MAIN
*************************************/
if (writeFileHeader(OUT_FILE))
{
        OUTPUT << (dateAndTime(today) "\n")
        
        Skip AllUserList = create
        int cnt = 0
        
        User user = null 
        for user in userList do {
                string temp = user.name
                put(AllUserList, cnt++, temp)
        }
 
        string cuuser = null 
        for cuuser in AllUserList do {
                UpdateUsers(cuuser, sgroup)
        }
        delete AllUserList
}
close OUTPUT
 
exit_

Re: Add all user to a group(help needed)
llandale - Wed Dec 05 12:42:57 EST 2012

pragma runLim, 0
 
const string sgroup = "DB Admin"
 
// Environment variable
const string USER_PROFILE = getenv("USERPROFILE") // Desktop variable
// -------------------------------------------------------------------
const string OUT_FILE = USER_PROFILE "\\Desktop\\UserGroupUpdate.txt"
const Stream OUTPUT
// -------------------------------------------------------------------
bool writeFileHeader(string filename)
{ // Try to open output file
  bool returnValue = false
  if (canOpenFile(filename, true))
  { // User can write to Stream
    returnValue = true
    OUTPUT = write filename
  } // User can write to Stream
  return returnValue
} // Try to open output file
// -------------------------------------------------------------------
    
void msgPrint(string msg)
{
        OUTPUT << msg
}
 
void UpdateUsers(string sUserName, string sgroup)
{
        bool saving = false
        
        if(existsGroup(sgroup))
        {
                Group g = find(sgroup)
                if(g == null)
                {
                        // warn user
                        msgPrint("Failed to find group.\n")
                }
                else
                {
                        User cUser = find(sUserName)
                        if(cUser == null)
                        {
                                // warn user
                                msgPrint("Failed to find user. '"sUserName".\n")
                        }
                        else
                        {
                                if(!member(g,cUser))
                                {            
                                        // add user group
                                        addMember(g, cUser)
                                        saving = true
                                }
                        }
                }
        }
        else
        {
                // warn user
                msgPrint("Group doesn't exist '"sgroup"'.\n")
        }
        
        if(saving)
        {
                // save new user list
                if (saveDirectory() == null) 
                {
                   // refresh
                   if (loadDirectory() == null)
                   {
                         // inform user
                         msgPrint("User '"sUserName"'was added successfully.\n")
                   } 
                   else 
                   {
                         // warn user
                         msgPrint("Failed to load user list.\n")
                   }
                } 
                else 
                {
                        // warn user
                        msgPrint("Failed to save user list.\n")
                }
        }
}
 
 
 
/************************************
        MAIN
*************************************/
if (writeFileHeader(OUT_FILE))
{
        OUTPUT << (dateAndTime(today) "\n")
        
        Skip AllUserList = create
        int cnt = 0
        
        User user = null 
        for user in userList do {
                string temp = user.name
                put(AllUserList, cnt++, temp)
        }
 
        string cuuser = null 
        for cuuser in AllUserList do {
                UpdateUsers(cuuser, sgroup)
        }
        delete AllUserList
}
close OUTPUT
 
exit_

• .. I'm guessing may cause some timing problems; but that is just my intuition (or paranoia) talking.
• .. I don't think you need the loadDirectory in any case
• .. you should saveDirectory after making all the changes.
• .. I think you need an initial loadDirectory call.

• close(OUTFILE) should move up inside the bracket.
• consider showing the file to the user when done:
  • system ("notepad.exe " OUT_FILE)
• I don't think you should want to "exit_" when done.